tuteng commented on a change in pull request #3268: Optimization of binlog to
pulsar use canal
URL: https://github.com/apache/pulsar/pull/3268#discussion_r244569918
##########
File path:
pulsar-io/canal/src/main/java/org/apache/pulsar/io/canal/CanalAbstractSource.java
##########
@@ -131,10 +124,11 @@ protected void process() {
connector.subscribe();
while (running) {
Message message =
connector.getWithoutAck(canalSourceConfig.getBatchSize());
- // delete the setRaw in new version of canal-client
message.setRaw(false);
- List<FlatMessage> flatMessages =
FlatMessage.messageConverter(message);
- long batchId = message.getId();
+ SimpleCanalConnector con = (SimpleCanalConnector)
connector;
+ con.isLazyParseEntry();
Review comment:
This line of code is useless. It should be generated automatically when
changing files. I didn't notice it. Now I have removed it. Please review the
code again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
