ConcurrencyPractitioner commented on a change in pull request #3273: Adding 
config auto.offset.reset to PulsarKafkaConsumer
URL: https://github.com/apache/pulsar/pull/3273#discussion_r244818217
 
 

 ##########
 File path: 
pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
 ##########
 @@ -65,6 +66,7 @@
 
 @Slf4j
 public class PulsarKafkaConsumer<K, V> implements Consumer<K, V>, 
MessageListener<byte[]> {
+    private static enum OffsetResetStrategy {EARLIEST, LATEST, NONE}
 
 Review comment:
   Well, I used SubscriptionInitialPosition later. We would still need to seek 
to the start or the end depending on the config setting. @merlimat Do you want 
me to get rid of the enum?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to