jerrypeng closed pull request #3271: remove function details from v3 function
endpoints
URL: https://github.com/apache/pulsar/pull/3271
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
index 3d81f836cf..73af2c56d3 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
@@ -79,11 +79,10 @@ public void registerFunction(final @PathParam("tenant")
String tenant,
final @FormDataParam("data") InputStream
uploadedInputStream,
final @FormDataParam("data")
FormDataContentDisposition fileDetail,
final @FormDataParam("url") String
functionPkgUrl,
- final @FormDataParam("functionDetails")
String functionDetailsJson,
final @FormDataParam("functionConfig") String
functionConfigJson) {
functions.registerFunction(tenant, namespace, functionName,
uploadedInputStream, fileDetail,
- functionPkgUrl, functionDetailsJson, functionConfigJson,
clientAppId());
+ functionPkgUrl, null, functionConfigJson, clientAppId());
}
@PUT
@@ -101,11 +100,10 @@ public void updateFunction(final @PathParam("tenant")
String tenant,
final @FormDataParam("data") InputStream
uploadedInputStream,
final @FormDataParam("data")
FormDataContentDisposition fileDetail,
final @FormDataParam("url") String
functionPkgUrl,
- final @FormDataParam("functionDetails") String
functionDetailsJson,
final @FormDataParam("functionConfig") String
functionConfigJson) {
functions.updateFunction(tenant, namespace, functionName,
uploadedInputStream, fileDetail,
- functionPkgUrl, functionDetailsJson, functionConfigJson,
clientAppId());
+ functionPkgUrl, null, functionConfigJson, clientAppId());
}
diff --git
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionApiV3Resource.java
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionApiV3Resource.java
index d25f8f9405..2eebf62285 100644
---
a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionApiV3Resource.java
+++
b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/FunctionApiV3Resource.java
@@ -66,11 +66,10 @@ public void registerFunction(final @PathParam("tenant")
String tenant,
final @FormDataParam("data") InputStream
uploadedInputStream,
final @FormDataParam("data")
FormDataContentDisposition fileDetail,
final @FormDataParam("url") String
functionPkgUrl,
- final @FormDataParam("functionDetails")
String functionDetailsJson,
final @FormDataParam("functionConfig") String
functionConfigJson) {
functions.registerFunction(tenant, namespace, functionName,
uploadedInputStream, fileDetail,
- functionPkgUrl, functionDetailsJson, functionConfigJson,
clientAppId());
+ functionPkgUrl, null, functionConfigJson, clientAppId());
}
@@ -83,11 +82,10 @@ public void updateFunction(final @PathParam("tenant")
String tenant,
final @FormDataParam("data") InputStream
uploadedInputStream,
final @FormDataParam("data")
FormDataContentDisposition fileDetail,
final @FormDataParam("url") String
functionPkgUrl,
- final @FormDataParam("functionDetails") String
functionDetailsJson,
final @FormDataParam("functionConfig") String
functionConfigJson) {
functions.updateFunction(tenant, namespace, functionName,
uploadedInputStream, fileDetail,
- functionPkgUrl, functionDetailsJson, functionConfigJson,
clientAppId());
+ functionPkgUrl, null, functionConfigJson, clientAppId());
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
