sijie commented on a change in pull request #3273: Adding config 
auto.offset.reset to PulsarKafkaConsumer
URL: https://github.com/apache/pulsar/pull/3273#discussion_r245169023
 
 

 ##########
 File path: 
pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
 ##########
 @@ -159,6 +163,15 @@ private PulsarKafkaConsumer(ConsumerConfig config, 
Deserializer<K> keyDeserializ
         }
     }
 
+    private SubscriptionInitialPosition getStrategy(final String strategy) {
+        switch(strategy) {
+           case "earliest":
+               return SubscriptionInitialPosition.Earliest;
+           default:
+                   return SubscriptionInitialPosition.Latest;
 
 Review comment:
   PulsarKafkaConsumer was shaded to `KafkaConsumer`. so if there are test 
failures, it should be related.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to