jerrypeng commented on a change in pull request #3383: refactor
AuthorizationProvider interface to allow custom logic for determining super user
URL: https://github.com/apache/pulsar/pull/3383#discussion_r248884008
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -176,9 +178,23 @@ protected void validateSuperUserAccess() {
validateOriginalPrincipal(pulsar.getConfiguration().getProxyRoles(), appId,
originalPrincipal);
if (pulsar.getConfiguration().getProxyRoles().contains(appId)) {
- Set<String> superUserRoles =
pulsar.getConfiguration().getSuperUserRoles();
- boolean proxyAuthorized = superUserRoles.contains(appId);
- boolean originalPrincipalAuthorized =
superUserRoles.contains(originalPrincipal);
+
+ boolean proxyAuthorized;
+ boolean originalPrincipalAuthorized;
+
+ try {
+ proxyAuthorized = pulsar.getBrokerService()
Review comment:
will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
