ambition119 commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248902896
########## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ########## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.io.hbase; + +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; +import lombok.experimental.Accessors; +import org.apache.commons.lang.StringUtils; +import org.apache.pulsar.io.core.annotations.FieldDoc; + +import java.io.Serializable; + +/** + * Configuration object for all Hbase Sink components. + */ +@Data +@Setter +@Getter +@EqualsAndHashCode +@ToString +@Accessors(chain = true) +public class HbaseAbstractConfig implements Serializable { + + private static final long serialVersionUID = 6783394446906640112L; + + @FieldDoc( + required = false, + defaultValue = "", + help = "hbase system configuration 'hbase-site.xml' file") + private String hbaseConfigResources; + + @FieldDoc( + required = true, + defaultValue = "", + help = "hbase system configuration about hbase.zookeeper.quorum value") + private String zookeeperQuorum; + + @FieldDoc( + required = true, + defaultValue = "2181", + help = "hbase system configuration about hbase.zookeeper.property.clientPort value") + private String zookeeperClientPort = "2181"; + + @FieldDoc( + required = true, Review comment: > If the setting already has a default value, it is not required any more, no? ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
