sijie commented on issue #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi URL: https://github.com/apache/pulsar/pull/3379#issuecomment-458271534 @ambition119 : > users use browsers to develop dataflow using nifi controls. documentation is great! but I think we should also have integration tests to make sure all the code in pulsar repo are well tested in a high quality manner. So everyone is encouraged to have an integration test for a new feature. However if you don't want to add one test in your current PR, please create a github issue for tracking the task of adding integration tests for NIFI connector. For adding an integration test, you can checkout the tests at https://github.com/apache/pulsar/tree/master/tests You can check plenty examples of integration tests for different IO connectors. for example, here is the kafka one - https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/KafkaSinkTester.java
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
