rdhabalia opened a new pull request #3479: [pulsar-broker] Avoid creating 
unnecessary dispatch-rate-limit objects
URL: https://github.com/apache/pulsar/pull/3479
 
 
   ### Motivation
   
   Right now, every topic creates rate-limiter object for 
[topic-level-limiter](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L170),
 
[subscriber-level-limiter](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L171),
 
[dispatcher-level-limiter](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java#L374)
 even though throttling is not configured. And subscriber dispatcher creates 
consumer-level limiter. So, it makes broker to create large number of 
`DispatchRateLimiter` objects and String objects even though throttling is 
disable.
   
   ### Modification
   Avoid creating unnecessary `DispatchRateLimiter` objects that can reduce gc 
impact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to