merlimat commented on a change in pull request #3487: When cursor recovery 
encounters empty cursor ledger, fallback to latest snapshot
URL: https://github.com/apache/pulsar/pull/3487#discussion_r252513665
 
 

 ##########
 File path: 
managed-ledger/src/test/java/org/apache/bookkeeper/client/PulsarMockBookKeeper.java
 ##########
 @@ -249,6 +249,14 @@ void checkProgrammedFail() throws BKException, 
InterruptedException {
         }
     }
 
+    synchronized boolean checkReturnEmptyLedger() {
+        if (emptyLedgerAfter-- == 0) {
 
 Review comment:
   Sure, will change though in this case the decrement has to be done after the 
comparison

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to