sijie commented on a change in pull request #3486: [pulsar-broker] separate
broker-client config to allow-insecure-cnx for broker replication
URL: https://github.com/apache/pulsar/pull/3486#discussion_r252888264
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -563,7 +563,7 @@ public PulsarClient getReplicationClient(String cluster) {
: data.getServiceUrlTls())
.enableTls(true)
.tlsTrustCertsFilePath(pulsar.getConfiguration().getBrokerClientTrustCertsFilePath())
-
.allowTlsInsecureConnection(pulsar.getConfiguration().isTlsAllowInsecureConnection());
+
.allowTlsInsecureConnection(pulsar.getConfiguration().isBrokerClientTlsAllowInsecureConnection());
Review comment:
@rdhabalia if people already specify tlsAllowInsecureConnection to true, and
when it upgrades to 2.3.0, he doesn't specify
brokerClientTlsAllowInsecureConnection to true, then it is a breaking behavior,
no?
Either we should change concurrent configuration loading logic to have the
ability to check if a setting is specified or not, or we should document this
for people to know how to configure the behavior when upgrading to 2.3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
