jerrypeng commented on a change in pull request #3703: Added support for 
"negative acks" in Java client
URL: https://github.com/apache/pulsar/pull/3703#discussion_r260900010
 
 

 ##########
 File path: 
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
 ##########
 @@ -187,6 +187,21 @@
      */
     ConsumerBuilder<T> ackTimeout(long ackTimeout, TimeUnit timeUnit);
 
+    /**
+     * Set the delay to wait before re-delivering messages that have failed to 
be process.
+     * <p>
+     * When application uses {@link Consumer#negativeAcknowledge(Message)}, 
the failed message
+     * will be redelivered after a fixed timeout. The default is 1 min.
 
 Review comment:
   can we make this comment more accurate since that is not necessarily going 
to be true.  Messages can be redelivered anytime from 0 - timeout

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to