eolivelli commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r261580781
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataSource.java
##########
@@ -82,36 +84,47 @@ default String getHttpHeader(String name) {
/**
* Check if data from Pulsar protocol are available.
- *
+ *
* @return true if this authentication data contain data from Pulsar
protocol
*/
default boolean hasDataFromCommand() {
return false;
}
/**
- *
+ *
* @return authentication data which is stored in a command
*/
default String getCommandData() {
return null;
}
+ /**
+ * For mutual authentication, This method use passed in `data` to evaluate
and challenge,
Review comment:
The content is good.
But we should reword this comment, it is not well written IMHO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
