ivankelly commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r262014275
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java
##########
@@ -105,6 +105,18 @@ public String authenticateHttpRequest(HttpServletRequest
request) throws Authent
}
}
+ public AuthenticationProvider getAuthenticationProvider(String
authMethodName) {
+ return providers.get(authMethodName);
+ }
+
+ public String getAnonymousUserRole() throws AuthenticationException {
+ if (StringUtils.isNotBlank(anonymousUserRole)) {
+ return anonymousUserRole;
+ }
+ // If at least a provider was configured, then the authentication
needs to be provided
Review comment:
I don't see any checking here to see if a provider was configured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
