ivankelly commented on a change in pull request #3690: [schema] Introduce
GenericRecordBuilder and the avro implementation
URL: https://github.com/apache/pulsar/pull/3690#discussion_r262027147
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericAvroSchema.java
##########
@@ -78,4 +79,8 @@ public GenericRecord decode(byte[] bytes, byte[]
schemaVersion) {
}
}
+ @Override
+ public GenericRecordBuilder newRecordBuilder() {
Review comment:
Since the builder only handled primative types, we should throw an exception
if we try to create a builder with a schema that has complex types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
