congbobo184 commented on a change in pull request #3752: revise the schema
default type not null
URL: https://github.com/apache/pulsar/pull/3752#discussion_r262821945
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicSchema.java
##########
@@ -124,10 +124,10 @@ private static SchemaType getDefaultSchemaType(Class<?>
clazz) {
return (Schema<T>) Schema.STRING;
case AVRO:
- return AvroSchema.of(clazz);
+ return AvroSchema.of(clazz,true);
case JSON:
- return JSONSchema.of(clazz);
+ return JSONSchema.of(clazz,true);
Review comment:
#3765 need to support disabling AllowNull
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
