jiazhai commented on a change in pull request #3847: Fix set-project-version.sh URL: https://github.com/apache/pulsar/pull/3847#discussion_r266242006
########## File path: src/set-project-version.sh ########## @@ -33,6 +33,9 @@ pushd $(dirname "$0")/.. mvn versions:set -DnewVersion=$NEW_VERSION mvn versions:set -DnewVersion=$NEW_VERSION -pl buildtools mvn versions:set -DnewVersion=$NEW_VERSION -pl pulsar-sql/presto-distribution +# install the new version of root pom local, so `update-parent` can update the right parent version +mvn -am -pl . clean install -DskipTests +mvn versions:update-parent -DallowSnapshots=true -DparentVersion=$NEW_VERSION -f protobuf-shaded/pom.xml mvn versions:set -DnewVersion=$NEW_VERSION -f protobuf-shaded/pom.xml Review comment: If update-parent worked well, then we could remove this line? @merlimat ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
