lhotari commented on a change in pull request #14093:
URL: https://github.com/apache/pulsar/pull/14093#discussion_r797885930



##########
File path: docker/pulsar/Dockerfile
##########
@@ -48,17 +48,13 @@ RUN sed -i 
"s|http://archive\.ubuntu\.com/ubuntu/|${UBUNTU_MIRROR:-mirror://mirr
      && apt-get update \
      && apt-get -y dist-upgrade \
      && apt-get -y install openjdk-11-jdk-headless netcat dnsutils less procps 
iputils-ping \
-                 python3 python3-dev python3-setuptools python3-yaml 
python3-kazoo \
-                 libreadline-gplv2-dev libncursesw5-dev libssl-dev 
libsqlite3-dev tk-dev libgdbm-dev libc6-dev libbz2-dev \
+                 python3 python3-yaml python3-kazoo python3-pip \

Review comment:
       `apt-get install --no-install-recommends python3-pip` seems omit GCC and 
a lot of other stuff.
   
   Could be verified with a "simulated" apt-get install by passing `-s`:
   ```
   docker run --rm -it ubuntu:20.04 bash -c 'apt-get update && apt-get install 
-s --no-install-recommends python3-pip'
   ```
   vs.
   ```
   docker run --rm -it ubuntu:20.04 bash -c 'apt-get update && apt-get install 
-s python3-pip'
   ```
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to