Jason918 commented on a change in pull request #14068:
URL: https://github.com/apache/pulsar/pull/14068#discussion_r798184951



##########
File path: 
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
##########
@@ -736,7 +736,7 @@ private static void runProducer(int producerId,
                     }
                     //generate msg key
                     if (msgKeyMode == MessageKeyGenerationMode.random) {
-                        messageBuilder.key(String.valueOf(random.nextInt()));
+                        
messageBuilder.key(String.valueOf(random.nextInt(Integer.MAX_VALUE)));

Review comment:
       Can you explain some details about this change? 

##########
File path: 
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerformanceProducerTest.java
##########
@@ -119,7 +120,7 @@ public void testMsgKey() throws Exception {
         }
 
         //use msg key generator,so every consumer can get msg
-        String newArgString = "%s -r 10 -u %s -m 500 -mk autoIncrement";
+        String newArgString = "%s -r 10 -u %s -m 500 -mk random";

Review comment:
       What's wrong with autoIncrement?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to