lhotari edited a comment on pull request #14099: URL: https://github.com/apache/pulsar/pull/14099#issuecomment-1029264533
> JDK8 won't compile with `--add-opens` flag. we need to remove jdk8 compile compatibility first. @nicoloboschi I don't think so. You should add the `--add-opens java.base/java.lang=ALL-UNNAMED` in a different location. there is `test.additional.args` property for this purpose. It should be fine to add `--add-opens java.base/java.lang=ALL-UNNAMED` to the existing jdk11 profile (we should avoid adding a jdk17 if we can): https://github.com/apache/pulsar/blob/3c29c7e9c31b1f44ce86ba91f34a5127b3409dfa/pom.xml#L1881-L1882 I believe it is fine to add `--add-opens java.base/java.lang=ALL-UNNAMED` for JDK11+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
