Jason918 opened a new pull request #14133:
URL: https://github.com/apache/pulsar/pull/14133
### Motivation
`failPendingRequest()` is changed to be executed in internalPinnedExecutor
in #13135
But `pendingRequests.clear()` is called right after `failPendingRequest()`,
so `pendingRequests` is always empty when the codes in failPendingRequest is
executed.
### Modifications
1. Remove `failPendingRequest()` out of internalPinnedExecutor. It's already
executed in internalPinnedExecutor.
2. Changes `pendingRequests.keys()` to `pendingRequests.forEach`, as
`ConcurrentLongHashMap#keys` makes a array copy of keys.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as
org.apache.pulsar.client.impl.TransactionClientConnectTest#testPulsarClientCloseThenCloseTcClient
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
