RobertIndie commented on a change in pull request #13758:
URL: https://github.com/apache/pulsar/pull/13758#discussion_r800396582
##########
File path: site2/docs/reference-configuration.md
##########
@@ -370,6 +367,22 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| brokerEntryMetadataInterceptors | Set broker entry metadata interceptors.<br
/><br />Multiple interceptors should be separated by commas. <br /><br
/>Available
values:<li>org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor</li><li>org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor</li>
<br /><br />Example<br
/>brokerEntryMetadataInterceptors=org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor,
org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor|N/A |
| enableExposingBrokerEntryMetadataToClient|Whether to expose broker entry
metadata to client or not.<br /><br />Available
values:<li>true</li><li>false</li><br />Example<br
/>enableExposingBrokerEntryMetadataToClient=true | false |
+
+### Deprecated Parameters
+The following parameters have been deprecated.
+
+|Name|Description|Default|
+|---|---|---|
+|backlogQuotaDefaultLimitGB| Use `backlogQuotaDefaultLimitBytes` instead. |-1|
+|brokerServicePurgeInactiveFrequencyInSeconds| Use
`brokerDeleteInactiveTopicsFrequencySeconds`.|60|
+|tlsEnabled| Use `webServicePortTls` and `brokerServicePortTls` instead.
|false|
+|replicationTlsEnabled| Enable TLS when talking with other clusters to
replicate messages |false|
Review comment:
```suggestion
|replicationTlsEnabled| Enable TLS when talking with other clusters to
replicate messages. Use `brokerClientTlsEnabled` instead. |false|
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -370,6 +367,22 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| brokerEntryMetadataInterceptors | Set broker entry metadata interceptors.<br
/><br />Multiple interceptors should be separated by commas. <br /><br
/>Available
values:<li>org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor</li><li>org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor</li>
<br /><br />Example<br
/>brokerEntryMetadataInterceptors=org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor,
org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor|N/A |
| enableExposingBrokerEntryMetadataToClient|Whether to expose broker entry
metadata to client or not.<br /><br />Available
values:<li>true</li><li>false</li><br />Example<br
/>enableExposingBrokerEntryMetadataToClient=true | false |
+
+### Deprecated Parameters
+The following parameters have been deprecated.
+
+|Name|Description|Default|
+|---|---|---|
+|backlogQuotaDefaultLimitGB| Use `backlogQuotaDefaultLimitBytes` instead. |-1|
+|brokerServicePurgeInactiveFrequencyInSeconds| Use
`brokerDeleteInactiveTopicsFrequencySeconds`.|60|
+|tlsEnabled| Use `webServicePortTls` and `brokerServicePortTls` instead.
|false|
+|replicationTlsEnabled| Enable TLS when talking with other clusters to
replicate messages |false|
+|subscriptionKeySharedEnable| Whether to enable the Key_Shared
subscription.|true|
Review comment:
I checked the code. `subscriptionKeySharedEnable ` seems not to be the
deprecated parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
