315157973 commented on a change in pull request #14061:
URL: https://github.com/apache/pulsar/pull/14061#discussion_r800403287
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -4837,7 +4839,9 @@ private void
internalGetReplicatedSubscriptionStatusForNonPartitionedTopic(Async
}
protected CompletableFuture<Void>
internalSetSchemaCompatibilityStrategy(SchemaCompatibilityStrategy strategy) {
- return validateTopicOperationAsync(topicName,
TopicOperation.SET_SCHEMA_COMPATIBILITY_STRATEGY)
+ return validateTopicPolicyOperationAsync(topicName,
+ PolicyName.SCHEMA_COMPATIBILITY_STRATEGY,
Review comment:
Could there be a compatibility issue here?
In addition, please add a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
