imaffe commented on a change in pull request #13987:
URL: https://github.com/apache/pulsar/pull/13987#discussion_r800410644



##########
File path: 
site2/website-next/versioned_docs/version-2.6.3/administration-zk-bk.md
##########
@@ -205,6 +210,9 @@ ledgerDirectories=data/bookkeeper/ledgers
 # Point to local ZK quorum
 zkServers=zk1.example.com:2181,zk2.example.com:2181,zk3.example.com:2181
 
+#This parameter best be set, otherwise,the Bookkeeper can't start normally in 
special environment

Review comment:
       Curious what the special environment is, is it possible to describe the 
special environment in a few sentences ?  Also if not set will there be a 
default value for this `advertisedAddress` ?

##########
File path: 
site2/website-next/versioned_docs/version-2.6.3/administration-zk-bk.md
##########
@@ -194,6 +194,11 @@ You can configure BookKeeper bookies using the 
[`conf/bookkeeper.conf`](referenc
 
 The minimum configuration changes required in `conf/bookkeeper.conf` are as 
follows:
 
+> **Note**  
+> The configuration of journalDirectory and ledgerDirectories needs to be 
considered clearly, and it is very troublesome to change later.

Review comment:
       nit: "needs to be chosen carefully, as it is troublesome to change later"

##########
File path: site2/website/versioned_docs/version-2.6.3/administration-zk-bk.md
##########
@@ -156,11 +170,12 @@ The 
[`conf/zookeeper.conf`](reference-configuration.md#zookeeper) file handles t
 
 The 
[`conf/global-zookeeper.conf`](reference-configuration.md#configuration-store) 
file handles the configuration for configuration store. The table below shows 
the available parameters:
 
+
 ## BookKeeper
 
 BookKeeper stores all durable message in Pulsar. BookKeeper is a distributed 
[write-ahead log](https://en.wikipedia.org/wiki/Write-ahead_logging) WAL system 
that guarantees read consistency of independent message logs calls ledgers. 
Individual BookKeeper servers are also called *bookies*.
 
-> To manage message persistence, retention, and expiry in Pulsar, refer to 
[cookbook](cookbooks-retention-expiry.md).
+> To manage message persistence, retention, and expiry in Pulsar, refer to 
[cookbook](cookbooks-retention-expiry).

Review comment:
       is it because the file does not have a .md postfix or the markdown 
doesn't need the .md postfix




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to