sijie commented on a change in pull request #3854: [issue #3767] support go
function for pulsar
URL: https://github.com/apache/pulsar/pull/3854#discussion_r266863001
##########
File path:
pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderconfigurator/DefaultSecretsProviderConfigurator.java
##########
@@ -39,7 +39,9 @@ public String
getSecretsProviderClassName(Function.FunctionDetails functionDetai
case JAVA:
return ClearTextSecretsProvider.class.getName();
case PYTHON:
- return "secretsprovider.ClearTextSecretsProvider";
+ return "secretsprovider.ClearTextSecretsProvider python";
+ case GO:
Review comment:
remove this branch here. we should let it throw runtime exception since go
doesn't support it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services