gaoran10 commented on a change in pull request #14145:
URL: https://github.com/apache/pulsar/pull/14145#discussion_r801250261
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/ManagedLedgerWriter.java
##########
@@ -151,6 +156,12 @@ public static void main(String[] args) throws Exception {
PerfClientUtils.exit(-1);
}
+ if (arguments.metadataStoreUrl == null && arguments.zookeeperServers
== null) {
Review comment:
Does the param `arguments.zookeeperServers ` still be useful?
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/ManagedLedgerWriter.java
##########
@@ -164,19 +175,23 @@ public static void main(String[] args) throws Exception {
// Now processing command line arguments
String managedLedgerPrefix = "test-" +
DigestUtils.sha1Hex(UUID.randomUUID().toString()).substring(0, 5);
+ if (arguments.metadataStoreUrl == null) {
+ arguments.metadataStoreUrl = arguments.zookeeperServers;
+ }
+
ClientConfiguration bkConf = new ClientConfiguration();
bkConf.setUseV2WireProtocol(true);
bkConf.setAddEntryTimeout(30);
bkConf.setReadEntryTimeout(30);
bkConf.setThrottleValue(0);
bkConf.setNumChannelsPerBookie(arguments.maxConnections);
- bkConf.setZkServers(arguments.zookeeperServers);
+ bkConf.setMetadataServiceUri(arguments.metadataStoreUrl);
Review comment:
It seems that only the param `arguments.metadataStoreUrl` is valid,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
