codelipenghui commented on a change in pull request #14114:
URL: https://github.com/apache/pulsar/pull/14114#discussion_r801805416
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
##########
@@ -446,5 +447,27 @@ private synchronized void
deleteDynamicConfigurationOnZk(String configName) {
public String version() throws Exception {
return PulsarVersion.getVersion();
}
+
+ @POST
+ @Path("/shutdown")
+ @ApiOperation(value =
+ "Shutdown broker gracefully.")
+ @ApiResponses(value = {
+ @ApiResponse(code = 204, message = "Execute shutdown command
successfully"),
+ @ApiResponse(code = 403, message = "You don't have admin
permission to update service-configuration"),
+ @ApiResponse(code = 500, message = "Internal server error")})
+ public void shutDownBrokerGracefully(
+ @QueryParam("maxConcurrentUnloadPerSec") int
maxConcurrentUnloadPerSec,
+ @QueryParam("forcedTerminateTopic") @DefaultValue("true") boolean
forcedTerminateTopic
Review comment:
Does the default value is `true` if without `?forcedTerminateTopic=true`?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
##########
@@ -446,5 +447,27 @@ private synchronized void
deleteDynamicConfigurationOnZk(String configName) {
public String version() throws Exception {
return PulsarVersion.getVersion();
}
+
+ @POST
+ @Path("/shutdown")
+ @ApiOperation(value =
+ "Shutdown broker gracefully.")
+ @ApiResponses(value = {
+ @ApiResponse(code = 204, message = "Execute shutdown command
successfully"),
+ @ApiResponse(code = 403, message = "You don't have admin
permission to update service-configuration"),
+ @ApiResponse(code = 500, message = "Internal server error")})
+ public void shutDownBrokerGracefully(
+ @QueryParam("maxConcurrentUnloadPerSec") int
maxConcurrentUnloadPerSec,
Review comment:
Better to add a description here, if the value absent(value=0) means no
concurrent limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
