aparajita89 commented on pull request #14102:
URL: https://github.com/apache/pulsar/pull/14102#issuecomment-1033408973


   comments from yesterday's review by @merlimat and ankur:
   
   * schema storage might not be used in custom schema registry, it need not be 
passed in the constructor
   * custom schema registry will require additional configs which will be 
present in ServiceConfiguration but it's not being passed to the constructor 
right now
   * evaluate the existing approach once more keeping in mind the above points


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to