nicoloboschi commented on a change in pull request #14098:
URL: https://github.com/apache/pulsar/pull/14098#discussion_r803044001
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
##########
@@ -180,7 +180,7 @@ public static ByteBuf newConnect(String authMethodName,
String authData, String
private static void setFeatureFlags(FeatureFlags flags) {
flags.setSupportsAuthRefresh(true);
flags.setSupportsBrokerEntryMetadata(true);
- flags.setSupportsPartialProducer(true);
+ // flags.setSupportsPartialProducer(true);
Review comment:
it was unintentional! glad you found it before this get merged
reverted now
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
##########
@@ -578,7 +578,7 @@ public static ByteBuf newSubscribe(String topic, String
subscription, long consu
keyValue.setValue(value);
keyValues.add(keyValue);
});
- subscribe.addAllSubscriptionProperties(keyValues);
+ // subscribe.addAllSubscriptionProperties(keyValues);
Review comment:
it was unintentional! glad you found it before this get merged
reverted now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
