rdhabalia commented on a change in pull request #13073:
URL: https://github.com/apache/pulsar/pull/13073#discussion_r803197711
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
##########
@@ -139,6 +139,8 @@ public synchronized void updateStats(
// this task: helps to activate
inactive-backlog-cursors which have caught up and
// connected, also deactivate
active-backlog-cursors which has backlog
topic.checkBackloggedCursors();
+ // check if topic is inactive and require
ledger rollover
+ ((PersistentTopic)
topic).checkInactiveLedgers();
Review comment:
as I explained earlier, this background thread performs topic's check
including stats, backlogged-cursor-check and this will be an additional one.
stats is something an essential part and its frequency should be reasonable
enough to handle this kind of check. I don't see any usecase for why anyone
disables the stats. however, if it's a real concern then will probably create
another PR to separate all topic's checks out of this dedicated thread. but
that can be addressed separately and definitely can not be a blocker for this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
