mattisonchao commented on pull request #14194: URL: https://github.com/apache/pulsar/pull/14194#issuecomment-1034374584
> -1. I don't think that making flakes pass silently is a good idea. For more context, please check the document [[Discuss] PIP Changes to flaky test handling](https://docs.google.com/document/d/10lmn4pW1IsT_8D1ZE0vMjASX0HhjdGdjB794iyScwns/edit) . > > > A critical problem of the current test retry solution is that it can mask bugs in production code and make the build pass and allow changes to be merged that cause regressions. There isn't a straight-forward way to detect whether the flakiness in a test is a result of a bad test or an actual bug in production code. Agree with @lhotari, Many flaky tests are actually production code issues so we need to track and resolve them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
