liudezhi2098 commented on a change in pull request #14069:
URL: https://github.com/apache/pulsar/pull/14069#discussion_r803468189
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java
##########
@@ -301,13 +301,21 @@ public void unloadTopic(@Suspended final AsyncResponse
asyncResponse, @PathParam
@ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Topic does not exist"),
@ApiResponse(code = 412, message = "Topic has active
producers/subscriptions")})
- public void deleteTopic(@PathParam("property") String property,
@PathParam("cluster") String cluster,
- @PathParam("namespace") String namespace, @PathParam("topic")
@Encoded String encodedTopic,
- @QueryParam("force") @DefaultValue("false") boolean force,
- @QueryParam("authoritative") @DefaultValue("false") boolean
authoritative,
- @QueryParam("deleteSchema") @DefaultValue("false") boolean
deleteSchema) {
+ public void deleteTopic(@Suspended AsyncResponse asyncResponse,
@PathParam("property") String property,
+ @PathParam("cluster") String cluster,
+ @PathParam("namespace") String namespace,
@PathParam("topic") @Encoded String encodedTopic,
+ @QueryParam("force") @DefaultValue("false")
boolean force,
+ @QueryParam("authoritative")
@DefaultValue("false") boolean authoritative,
+ @QueryParam("deleteSchema") @DefaultValue("false")
boolean deleteSchema) {
validateTopicName(property, cluster, namespace, encodedTopic);
Review comment:
need catch exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
