leizhiyuan opened a new pull request #14217:
URL: https://github.com/apache/pulsar/pull/14217


   now entry filter uses the first consumer properties to 
PersistentSubscription , but when users modified their code, and change the 
properties, it will not take effect.
   
   ### Motivation
   
   users use entry filter to implement tag filter, 
   
   time 1 : they use tag1 
   time 2 : users upgrade their code, and use tag2,
   
   We will not take effect, only restart all brokers or users restart their 
apps. it is impossible.
   
   *Explain here the context, and why you're making that change. What is the 
problem you're trying to solve.*
   
   ### Modifications
   
   
   override the properties every time. then when users upgrade their app, this 
will take effect.
   
   ### Verifying this change
   
   add test case
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer 
privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to