yuruguo commented on a change in pull request #14254:
URL: https://github.com/apache/pulsar/pull/14254#discussion_r805112410



##########
File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
##########
@@ -254,11 +254,11 @@ void run() throws PulsarAdminException {
         @Parameter(description = "tenant/namespace", required = true)
         private java.util.List<String> params;
 
-        @Parameter(names = "--subscription",
+        @Parameter(names = {"-s", "--subscription"},
                 description = "Subscription name for which permission will be 
granted to roles", required = true)
         private String subscription;
 
-        @Parameter(names = "--roles", description = "Client roles to which 
grant permissions (comma separated roles)",
+        @Parameter(names = {"-r", "--roles"}, description = "Client roles to 
which grant permissions (comma separated roles)",

Review comment:
       It is recommended to use the short name “-rs” instead of “-r”




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to