Jason918 commented on a change in pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#discussion_r805113922
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java
##########
@@ -196,6 +223,20 @@ public void incrementNumAcksReceived(long latencyNs) {
}
}
+ @Override
+ public void incrementBatchSize(int batchSize) {
Review comment:
`incrementBatchSize` and `incrementMsgSize` can be done in
`updateNumMsgsSent`, no need for new api.
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java
##########
@@ -196,6 +223,20 @@ public void incrementNumAcksReceived(long latencyNs) {
}
}
+ @Override
+ public void incrementBatchSize(int batchSize) {
Review comment:
And missed collect from send operation in
`org.apache.pulsar.client.impl.ProducerImpl#recoverProcessOpSendMsgFrom`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
