merlimat commented on a change in pull request #14283:
URL: https://github.com/apache/pulsar/pull/14283#discussion_r806384123
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStoreConfig.java
##########
@@ -69,4 +69,10 @@
*/
@Builder.Default
private final int batchingMaxSizeKb = 128;
+
+ /**
+ * Metadata store cache executor thread pool size.
+ */
+ @Builder.Default
+ private final int metadataCacheExecutorThreadPoolSize = 10;
Review comment:
What is the reason for having 10 threads?
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
##########
@@ -261,12 +268,17 @@ public void invalidate(String path) {
}
@Override
- public void refresh(String path) {
+ public CompletableFuture<Void> refresh(String path) {
// Refresh object of path if only it is cached before.
- if (objCache.getIfPresent(path) != null) {
- objCache.synchronous().invalidate(path);
- objCache.synchronous().refresh(path);
- }
+ CompletableFuture<Void> promise = new CompletableFuture<>();
+ scheduler.executeOrdered(path, () -> {
Review comment:
Why do we need to run in a different thread?
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStore.java
##########
@@ -159,4 +158,11 @@
* @return the metadata cache object
*/
<T> MetadataCache<T> getMetadataCache(MetadataSerde<T> serde);
+
+ /**
+ * Get metadata store config.
+ *
+ * @return the metadata store config.
+ */
+ MetadataStoreConfig getMetadataStoreConfig();
Review comment:
Why exposing the config as part of API here?
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/Notifiable.java
##########
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.metadata.api;
+
+import java.util.concurrent.CompletableFuture;
+
+public interface Notifiable<T> {
Review comment:
`Notifiable` doesn't sound correct as a name. Also, if we're always
using this with a `Notification` arg, we don't need this to be a generic type.
eg:
```java
interface NotificationListener {
CompletableFuture<Void> acceptAsync(Notification n);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
