lhotari commented on a change in pull request #14300:
URL: https://github.com/apache/pulsar/pull/14300#discussion_r807003538



##########
File path: jclouds-shaded/pom.xml
##########
@@ -44,6 +44,19 @@
       <groupId>javax.annotation</groupId>
       <artifactId>javax.annotation-api</artifactId>
     </dependency>
+    <!-- https://github.com/apache/jclouds/pull/123/files-->
+    <dependency>
+      <groupId>com.google.inject</groupId>
+      <artifactId>guice</artifactId>
+      <version>${guice.version}</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.google.inject.extensions</groupId>
+      <artifactId>guice-assistedinject</artifactId>
+      <version>${guice.version}</version>
+      <scope>runtime</scope>
+    </dependency>

Review comment:
       Would it be useful to add these to the root parent pom.xml's 
dependencyManagement / dependencies so that the correct versions get picked in 
all locations? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to