michaeljmarshall commented on a change in pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#discussion_r807207672
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -64,9 +64,9 @@ void run() throws Exception {
@Parameters(commandDescription = "Update dynamic-serviceConfiguration of
broker")
private class UpdateConfigurationCmd extends CliCommand {
- @Parameter(names = "--config", description = "service-configuration
name", required = true)
+ @Parameter(names = {"-c", "--config"}, description =
"service-configuration name", required = true)
private String configName;
- @Parameter(names = "--value", description = "service-configuration
value", required = true)
+ @Parameter(names = {"-v", "--value"}, description =
"service-configuration value", required = true)
Review comment:
I think we should reserve `-v` for verbose logging. I recognize that we
don't have this feature currently, but we could add it, and I don't believe
we're using `-v` yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
