lhotari commented on pull request #14320:
URL: https://github.com/apache/pulsar/pull/14320#issuecomment-1041533186


   > Change the default configuration need to start with a proposal
   
   This PR is a proposal. I have also make this proposal on the dev mailing 
list in the discussion. 
https://lists.apache.org/thread/byg1g081o6mfj0xn8ntryvb5qplmrjyl . What else is 
needed?
   
   In this case, the previous default for numHttpServerThreads is simply too 
small and invalid when blocking servlet API is used.
   The value 200 doesn't mean that there will be 200 threads to start with. 
This is the maximum size for the thread pool. When the value is more than 8, 
Jetty will start with 8 initial threads and add more threads to the pool when 
all threads are occupied.
   
   There is no breaking change in increasing the default value to 200. It's 
just an improvement and fixes "the problem" where Admin API goes unresponsive 
when all threads are occupied.
   
   We might end up setting the default value to something lower than 200. A 
value like 50 or 100 might be fine. I just think that 200 is a good default 
since Jetty also uses that as the default value.
   
   The main overhead of a thread is the amount of memory that the stack of each 
thread consumes. It's 1MB by default. 200 threads will consume 200MB of RSS 
memory in the thread stacks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to