mattisonchao commented on a change in pull request #14366:
URL: https://github.com/apache/pulsar/pull/14366#discussion_r810447008
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java
##########
@@ -162,12 +162,12 @@ public void createTenant(@Suspended final AsyncResponse
asyncResponse,
log.info("[{}] Created tenant {}", clientAppId(), tenant);
asyncResponse.resume(Response.noContent().build());
}).exceptionally(ex -> {
- log.error("[{}] Failed to create tenant {}", clientAppId,
tenant, e);
+ log.error("[{}] Failed to create tenant {}", clientAppId,
tenant, ex);
asyncResponse.resume(new RestException(ex));
return null;
});
}).exceptionally(ex -> {
- log.error("[{}] Failed to create tenant {}", clientAppId(),
tenant, e);
+ log.error("[{}] Failed to create tenant {}", clientAppId(),
tenant, ex);
asyncResponse.resume(new RestException(ex));
Review comment:
Maybe we need to unwrap the exception?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java
##########
@@ -162,12 +162,12 @@ public void createTenant(@Suspended final AsyncResponse
asyncResponse,
log.info("[{}] Created tenant {}", clientAppId(), tenant);
asyncResponse.resume(Response.noContent().build());
}).exceptionally(ex -> {
- log.error("[{}] Failed to create tenant {}", clientAppId,
tenant, e);
+ log.error("[{}] Failed to create tenant {}", clientAppId,
tenant, ex);
asyncResponse.resume(new RestException(ex));
Review comment:
Maybe we need to unwrap the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
