Jason918 commented on a change in pull request #14382:
URL: https://github.com/apache/pulsar/pull/14382#discussion_r810464635
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -439,7 +443,7 @@ public void sendAsync(Message<?> message, SendCallback
callback) {
// validate msg-size (For batching this will be check at the batch
completion size)
int compressedSize = compressedPayload.readableBytes();
- if (compressedSize > ClientCnx.getMaxMessageSize() &&
!this.conf.isChunkingEnabled()) {
+ if (compressedSize > chunkMaxMessageSize &&
!this.conf.isChunkingEnabled()) {
Review comment:
This should not be changed to `chunkMaxMessageSize`, otherwise we won't
be able to send message larger than `chunkMaxMessageSize` if chunking is
disabled.
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
##########
@@ -168,7 +168,8 @@
* will fail unless {@code blockIfQueueFull=true}. Use {@link
#blockIfQueueFull(boolean)}
* to change the blocking behavior.
*
- * <p>The producer queue size also determines the max amount of memory
that will be required by
+ * <p>The producer queue size also determin@Override
+ es the max amount of memory that will be required by
Review comment:
Seems not right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
