gaozhangmin commented on a change in pull request #13939:
URL: https://github.com/apache/pulsar/pull/13939#discussion_r810990107



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -292,6 +292,13 @@ ManagedCursor newNonDurableCursor(Position startPosition, 
String subscriptionNam
      */
     void deleteCursor(String name) throws InterruptedException, 
ManagedLedgerException;
 
+    /**
+     * Remove a ManagedCursor from this ManagedLedger's waitingCursors.
+     *
+     * @param cursor the ManagedCursor
+     */
+    void removeWaitingCursor(ManagedCursor cursor);

Review comment:
       `deactivateCursor` is widely used not only by closeConsumer, We cannot 
change the behavior of `deactivateCursor`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to