wuzhanpeng commented on a change in pull request #13575:
URL: https://github.com/apache/pulsar/pull/13575#discussion_r811038733
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2718,42 +2747,52 @@ public void deleteCursorFailed(ManagedLedgerException
exception, Object ctx) {
}
}
- private void asyncDeleteLedgerFromBookKeeper(long ledgerId) {
- asyncDeleteLedger(ledgerId, DEFAULT_LEDGER_DELETE_RETRIES);
- }
-
- private void asyncDeleteLedger(long ledgerId, LedgerInfo info) {
- if (!info.getOffloadContext().getBookkeeperDeleted()) {
- // only delete if it hasn't been previously deleted for offload
- asyncDeleteLedger(ledgerId, DEFAULT_LEDGER_DELETE_RETRIES);
- }
-
+ private void asyncDeleteOffloadedLedger(long ledgerId, LedgerInfo info,
int retry, DeleteLedgerCallback callback) {
if (info.getOffloadContext().hasUidMsb()) {
UUID uuid = new UUID(info.getOffloadContext().getUidMsb(),
info.getOffloadContext().getUidLsb());
cleanupOffloaded(ledgerId, uuid,
OffloadUtils.getOffloadDriverName(info,
config.getLedgerOffloader().getOffloadDriverName()),
OffloadUtils.getOffloadDriverMetadata(info,
config.getLedgerOffloader().getOffloadDriverMetadata()),
- "Trimming");
+ "Trimming", retry, callback);
}
}
private void asyncDeleteLedger(long ledgerId, long retry) {
+ asyncDeleteLedger(ledgerId, retry, new DeleteLedgerCallback() {
+ @Override
+ public void deleteLedgerComplete(Object ctx) {
+
Review comment:
This is the default implementation, which is used to be compatible with
the original logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
