michaeljmarshall commented on a change in pull request #14044:
URL: https://github.com/apache/pulsar/pull/14044#discussion_r811585855
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -310,9 +316,10 @@ private String getTokenAudience(ServiceConfiguration conf)
throws IllegalArgumen
private final AuthenticationProviderToken provider;
private AuthenticationDataSource authenticationDataSource;
private Jwt<?, Claims> jwt;
- private final SocketAddress remoteAddress;
- private final SSLSession sslSession;
+ private SocketAddress remoteAddress;
+ private SSLSession sslSession;
Review comment:
Nit: I think these can be removed now.
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -310,9 +316,10 @@ private String getTokenAudience(ServiceConfiguration conf)
throws IllegalArgumen
private final AuthenticationProviderToken provider;
private AuthenticationDataSource authenticationDataSource;
private Jwt<?, Claims> jwt;
- private final SocketAddress remoteAddress;
- private final SSLSession sslSession;
+ private SocketAddress remoteAddress;
+ private SSLSession sslSession;
private long expiration;
+ private HttpServletRequest request;
Review comment:
Nit: I don't think we need this reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
