tuteng commented on pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#issuecomment-1048399224
> LGTM. > > @tuteng - thanks for addressing my many comments. Also, I took a look at your bug report in #14404, and I personally don't think this can be classified as a bug. It is certainly a missing feature, and it is great that you've added it in. However, if it were a bug, we wouldn't maintain the current behavior as the default. > > I agree that this change appears backwards compatible, but given that it is an expansion of an interface, I think it should require additional attention before cherry-picking to stable release branches. Will you send a note to the mailing list describing the changes before starting any cherry-picking? Thanks. Thanks for your comment, then we keep this in 2.11 to release it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
