yaalsn opened a new pull request #14428: URL: https://github.com/apache/pulsar/pull/14428
Fixes #14388 ### Motivation In pulsar function, when the runtime is `Python` or `Java` , commands will start with `python` or `java` <img width="795" alt="image" src="https://user-images.githubusercontent.com/10069311/155286587-37d97742-b28a-4590-bb58-591166d11334.png"> This would be right in general, but sometimes is not such as `/home/pulsar/jdk17/bin/java`, `python3` and `conda` `pyenv` python virutalenv. We need to add a executor to let user to choose. ### Modifications - Add `--executor` parameter to `CmdFunctions`. - Add `executor` to `functions.proto` - Replace `java` and `python` with executor ### Verifying this change - [x] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - *Extend unit tests for args which contains executor to be parsed* - *Added integration tests for function run with executor* ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API: (yes / **no**) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / **no**) - The rest endpoints: (yes / **no**) - **The admin cli options**: (**yes** / no) - Anything that affects deployment: (yes / **no** / don't know) ### Documentation Need to update docs? - [x] `doc` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
