codelipenghui commented on a change in pull request #14411:
URL: https://github.com/apache/pulsar/pull/14411#discussion_r813846793
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -1079,6 +1091,18 @@ private void deleteBundleDataFromMetadataStore(String
bundle) {
}
}
+ private void deleteTimeAverageDataFromMetadataStore(String broker) {
+ final String timeAverageZPath = TIME_AVERAGE_BROKER_ZPATH + "/" +
broker;
+ try {
+ timeAverageBrokerDataCache.delete(timeAverageZPath).join();
Review comment:
The `updateAllBrokerData` will be called in the metadata listener
thread, looks like we using .join() here might introduce a deadlock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
