gaozhangmin commented on a change in pull request #14384:
URL: https://github.com/apache/pulsar/pull/14384#discussion_r814641505



##########
File path: 
pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -38,8 +38,8 @@ int getPackagesReplicas() {
         return Integer.parseInt(getProperty("packagesReplicas"));
     }
 
-    String getZookeeperServers() {
-        return getProperty("zookeeperServers");

Review comment:
       it's OK, values in  `BookKeeperPackagesStorageConfiguration.java come 
from broker and standalone configuration. 
   `configuration.getProperty("metadataStoreUrl")` will return either 
metadataStoreUrl  or zookeeperServers in config by 
`ServiceConfiguration.getMetadataStoreUrl`. @nicoloboschi 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to