michaeljmarshall commented on a change in pull request #14400:
URL: https://github.com/apache/pulsar/pull/14400#discussion_r815209200
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -721,9 +725,7 @@ public String toString() {
+ '}';
}
- protected void setMaxReceiverQueueSize(int newSize) {
- this.maxReceiverQueueSize = newSize;
- }
+ protected abstract void setMaxReceiverQueueSize(int newSize);
Review comment:
I see. I was basing my comment on the fact that the initial commit had
`setMaxReceiverQueueSize` set as a public method in the `ConsumerImpl`.
Assuming that it is meant to be `protected`, I agree that this method does not
belong in the `Consumer` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
