eolivelli commented on a change in pull request #14044:
URL: https://github.com/apache/pulsar/pull/14044#discussion_r815493328
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationDataBasic.java
##########
@@ -42,9 +46,7 @@ public boolean hasDataForHttp() {
@Override
public Set<Map.Entry<String, String>> getHttpHeaders() {
- Map<String, String> headers = new HashMap<>();
- headers.put(HTTP_HEADER_NAME, httpAuthToken);
- return headers.entrySet();
+ return Collections.unmodifiableMap(this.headers).entrySet();
Review comment:
Why are you wrapping it all the times instead of creating this wrapper
only once in the constructor? Here and in other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
