eolivelli commented on a change in pull request #14515:
URL: https://github.com/apache/pulsar/pull/14515#discussion_r816806141
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##########
@@ -161,8 +161,17 @@ default boolean isChunked() {
* @param option
* @return
*/
+ @Deprecated
CompletableFuture<Consumer> subscribe(SubscriptionOption option);
+ /**
+ * Subscribe a topic.
+ *
+ * @param autoShrink whether ConcurrentLongLongPairHashMap supports
automatic shrinking.
+ * @return
+ */
+ CompletableFuture<Consumer> subscribe(SubscriptionOption option, boolean
autoShrink);
Review comment:
this is global parameter, maybe you have another way to pass this way.
every Consumer will use the same value.
if you add a "parameter" in the function it means that it would be possible
to see different values and this is not true
I believe that overall we don't need a configuration flag at all.
your change is good and you demonstrated that it is needed
cc @merlimat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
